yzs981130/oyashirosama2: controllers/testjob_controller.go; 24 LoC

Found a possible issue in [yzs981130/oyashirosama2](https://www.github.com/yzs981130/oyashirosama2) at [controllers/testjob_controller.go](https://github.com/yzs981130/oyashirosama2/blob/c0c27bdd26dccfbd67eafa87bcfada4a6e0bc7f7/controllers/testjob_controller.go#L121-L144)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> function call which takes a reference to job at line 134 may start a goroutine

[Click here to see the code in its original context.](https://github.com/yzs981130/oyashirosama2/blob/c0c27bdd26dccfbd67eafa87bcfada4a6e0bc7f7/controllers/testjob_controller.go#L121-L144)

Click here to show the 24 line(s) of Go which triggered the analyzer.

```go
for i, job := range childJobs.Items {
_, finishedType := isJobFinished(&job)
switch finishedType {
case "": // ongoing
activeJobs = append(activeJobs, &childJobs.Items[i])
case schedulev1.JobFailed:
failedJobs = append(failedJobs, &childJobs.Items[i])
case schedulev1.JobComplete:
successfulJobs = append(successfulJobs, &childJobs.Items[i])
}

scheduledTimeForJob, err := getScheduledTimeForJob(&job)
if err != nil {
log.Error(err, "unable to parse schedule time for child job", "job", &job)
continue
}
if scheduledTimeForJob != nil {
if mostRecentTime == nil {
mostRecentTime = scheduledTimeForJob
} else if mostRecentTime.Before(*scheduledTimeForJob) {
mostRecentTime = scheduledTimeForJob
}
}
}

```

Click here to show extra information the analyzer produced.

```
The following dot graph describes paths through the callgraph that could lead to a function calling a goroutine:
no paths found; call may have ended in third-party code; stay tuned for diagnostics
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: c0c27bdd26dccfbd67eafa87bcfada4a6e0bc7f7