john-deng/hicli-vendor: github.com/openshift/origin/pkg/oc/cli/deploymentconfigs/delete.go; 27 LoC

Found a possible issue in [john-deng/hicli-vendor](https://www.github.com/john-deng/hicli-vendor) at [github.com/openshift/origin/pkg/oc/cli/deploymentconfigs/delete.go](https://github.com/john-deng/hicli-vendor/blob/bba4ecd772d120ba795d0d4d3f70db0b0bd0c508/github.com/openshift/origin/pkg/oc/cli/deploymentconfigs/delete.go#L100-L126)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> function call at line 108 may store a reference to rc

[Click here to see the code in its original context.](https://github.com/john-deng/hicli-vendor/blob/bba4ecd772d120ba795d0d4d3f70db0b0bd0c508/github.com/openshift/origin/pkg/oc/cli/deploymentconfigs/delete.go#L100-L126)

Click here to show the 27 line(s) of Go which triggered the analyzer.

```go
for _, rc := range deployments {
if err = rcReaper.Stop(rc.Namespace, rc.Name, timeout, gracePeriod); err != nil {
// Better not error out here...
glog.Infof("Cannot delete ReplicationController %s/%s for deployment config %s/%s: %v", rc.Namespace, rc.Name, namespace, name, err)
}

// Only remove deployer pods when the deployment was failed. For completed
// deployment the pods should be already deleted.
if !util.IsFailedDeployment(&rc) {
continue
}

// Delete all deployer and hook pods
podList, err := reaper.kc.Core().Pods(rc.Namespace).List(metav1.ListOptions{
LabelSelector: util.DeployerPodSelector(rc.Name).String(),
})
if err != nil {
return err
}
for _, pod := range podList.Items {
err := reaper.kc.Core().Pods(pod.Namespace).Delete(pod.Name, gracePeriod)
if err != nil {
// Better not error out here...
glog.Infof("Cannot delete lifecycle Pod %s/%s for deployment config %s/%s: %v", pod.Namespace, pod.Name, namespace, name, err)
}
}
}

```

Click here to show extra information the analyzer produced.

```
The following dot graph describes paths through the callgraph that could lead to a function which writes a pointer argument:
no paths found; call may have ended in third-party code; stay tuned for diagnostics
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: bba4ecd772d120ba795d0d4d3f70db0b0bd0c508