github-vet / github-vet/rangeloop-pointer-findings

john-deng/hicli-vendor: github.com/openshift/origin/pkg/oc/cli/cmd/image/mirror/mirror.go; 8 LoC

Open
#8,348 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [john-deng/hicli-vendor](https://www.github.com/john-deng/hicli-vendor) at [github.com/openshift/origin/pkg/oc/cli/cmd/image/mirror/mirror.go](https://github.com/john-deng/hicli-vendor/blob/bba4ecd772d120ba795d0d4d3f70db0b0bd0c508/github.com/openshift/origin/pkg/oc/cli/cmd/image/mirror/mirror.go#L605-L612)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> function call which takes a reference to manifest at line 606 may start a goroutine

[Click here to see the code in its original context.](https://github.com/john-deng/hicli-vendor/blob/bba4ecd772d120ba795d0d4d3f70db0b0bd0c508/github.com/openshift/origin/pkg/oc/cli/cmd/image/mirror/mirror.go#L605-L612)

Click here to show the 8 line(s) of Go which triggered the analyzer.

```go
for _, manifest := range t.Manifests {
if !filterFn(&manifest) {
glog.V(5).Infof("Skipping image for %#v from %s", manifest.Platform, ref)
continue
}
glog.V(5).Infof("Including image for %#v from %s", manifest.Platform, ref)
filtered = append(filtered, manifest)
}

```

Click here to show extra information the analyzer produced.

```
The following dot graph describes paths through the callgraph that could lead to a function calling a goroutine:
no paths found; call may have ended in third-party code; stay tuned for diagnostics
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: bba4ecd772d120ba795d0d4d3f70db0b0bd0c508

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.