github-vet / github-vet/rangeloop-pointer-findings

codepr/narwhal: backend/dispatcher.go; 15 LoC

Open
#8,316 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [codepr/narwhal](https://www.github.com/codepr/narwhal) at [backend/dispatcher.go](https://github.com/codepr/narwhal/blob/9fbb4a3ae8e7992ac6d978e09abce95a0512d38b/backend/dispatcher.go#L89-L103)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> function call which takes a reference to runner at line 102 may start a goroutine

[Click here to see the code in its original context.](https://github.com/codepr/narwhal/blob/9fbb4a3ae8e7992ac6d978e09abce95a0512d38b/backend/dispatcher.go#L89-L103)

Click here to show the 15 line(s) of Go which triggered the analyzer.

```go
for _, runner := range d.runners {
go func(runner *RunnerProxy) {
for {
event := <-events
var commit Commit
err := json.Unmarshal(event, &commit)
if err != nil {
log.Println("Error decoding commit event")
} else {
// push job to runner through runnerproxy
log.Printf("Pushing commit %v to runner\n", commit)
}
}
}(&runner)
}

```

Click here to show extra information the analyzer produced.

```
The following dot graph describes paths through the callgraph that could lead to a function calling a goroutine:
no paths found; call may have ended in third-party code; stay tuned for diagnostics
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 9fbb4a3ae8e7992ac6d978e09abce95a0512d38b

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.