github-vet / github-vet/rangeloop-pointer-findings

vmware/vmware-go-kcl: clientlibrary/worker/worker.go; 45 LoC

Open
#8,264 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [vmware/vmware-go-kcl](https://www.github.com/vmware/vmware-go-kcl) at [clientlibrary/worker/worker.go](https://github.com/vmware/vmware-go-kcl/blob/ff6f70df48ce60dbd38aa7b9dbdef0f3881eacf5/clientlibrary/worker/worker.go#L256-L300)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable shard used in defer or goroutine at line 294

[Click here to see the code in its original context.](https://github.com/vmware/vmware-go-kcl/blob/ff6f70df48ce60dbd38aa7b9dbdef0f3881eacf5/clientlibrary/worker/worker.go#L256-L300)

Click here to show the 45 line(s) of Go which triggered the analyzer.

```go
for _, shard := range w.shardStatus {
// already owner of the shard
if shard.GetLeaseOwner() == w.workerID {
continue
}

err := w.checkpointer.FetchCheckpoint(shard)
if err != nil {
// checkpoint may not existed yet is not an error condition.
if err != chk.ErrSequenceIDNotFound {
log.Errorf(" Error: %+v", err)
// move on to next shard
continue
}
}

// The shard is closed and we have processed all records
if shard.Checkpoint == chk.ShardEnd {
continue
}

err = w.checkpointer.GetLease(shard, w.workerID)
if err != nil {
// cannot get lease on the shard
if err.Error() != chk.ErrLeaseNotAcquired {
log.Errorf("Cannot get lease: %+v", err)
}
continue
}

// log metrics on got lease
w.mService.LeaseGained(shard.ID)

log.Infof("Start Shard Consumer for shard: %v", shard.ID)
sc := w.newShardConsumer(shard)
w.waitGroup.Add(1)
go func() {
defer w.waitGroup.Done()
if err := sc.getRecords(shard); err != nil {
log.Errorf("Error in getRecords: %+v", err)
}
}()
// exit from for loop and not to grab more shard for now.
break
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: ff6f70df48ce60dbd38aa7b9dbdef0f3881eacf5

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.