github-vet / github-vet/rangeloop-pointer-findings
yeeco/gyee: tests/common.go; 29 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [yeeco/gyee](https://www.github.com/yeeco/gyee) at [tests/common.go](https://github.com/yeeco/gyee/blob/05aca43e839014daa2d772ced8cdfa9a1f4b196d/tests/common.go#L80-L108)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable tn used in defer or goroutine at line 105
[Click here to see the code in its original context.](https://github.com/yeeco/gyee/blob/05aca43e839014daa2d772ced8cdfa9a1f4b196d/tests/common.go#L80-L108)
Click here to show the 29 line(s) of Go which triggered the analyzer.
```go
for j, tn := range nodes {
if j == i {
continue
}
// transfer f => t
tAddr := &addrs[j]
tx := core.NewTransaction(testChainID, nonces[i], tAddr, big.NewInt(100))
if err := tx.Sign(signers[i]); err != nil {
t.Errorf("sign failed %v", err)
continue
}
data, err := tx.Encode()
if err != nil {
t.Errorf("encode tx failed %v", err)
continue
}
nonces[i]++
go func(hash *common.Hash, data []byte) {
msg := &p2p.Message{
MsgType: p2p.MessageTypeTx,
Data: data,
}
_ = fn.P2pService().DhtSetValue(hash[:], data)
_ = fn.P2pService().BroadcastMessage(*msg)
fn.Core().FakeP2pRecv(msg)
tn.Core().FakeP2pRecv(msg)
}(tx.Hash(), data)
totalTxs++
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 05aca43e839014daa2d772ced8cdfa9a1f4b196d
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.