github-vet / github-vet/rangeloop-pointer-findings
Narsil/operational-transform-go: network.go; 17 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [Narsil/operational-transform-go](https://www.github.com/Narsil/operational-transform-go) at [network.go](https://github.com/Narsil/operational-transform-go/blob/c9d45687ffa6a6add2c83015f7663b9f6c87ee84/network.go#L28-L44)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable host used in defer or goroutine at line 30
[Click here to see the code in its original context.](https://github.com/Narsil/operational-transform-go/blob/c9d45687ffa6a6add2c83015f7663b9f6c87ee84/network.go#L28-L44)
Click here to show the 17 line(s) of Go which triggered the analyzer.
```go
for _, host := range doc.hosts{
go func(){
conn, err := net.Dial("tcp", host)
if err != nil{
log.Fatal("Dialing error", err)
}
conn.Write(str)
conn.Write([]byte{'0'})
buf := make([]byte, 3)
conn.Read(buf)
if string(buf) != "ACK"{
log.Fatal("Did not receive ACK")
}
sent_hosts <- 1
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: c9d45687ffa6a6add2c83015f7663b9f6c87ee84
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.