github-vet / github-vet/rangeloop-pointer-findings

tokitgit/tokit: src/tokit/generator/generator.go; 13 LoC

Open
#8,067 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [tokitgit/tokit](https://www.github.com/tokitgit/tokit) at [src/tokit/generator/generator.go](https://github.com/tokitgit/tokit/blob/7b2c93e51ab5db7649ee30d127dd374af6d6d711/src/tokit/generator/generator.go#L112-L124)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> function call at line 117 may store a reference to sheet

[Click here to see the code in its original context.](https://github.com/tokitgit/tokit/blob/7b2c93e51ab5db7649ee30d127dd374af6d6d711/src/tokit/generator/generator.go#L112-L124)

Click here to show the 13 line(s) of Go which triggered the analyzer.

```go
for _, sheet := range job.TargetExcel.Sheets {
var fileName string = sheet.EnName + "." + ext
var fullPath string = tool.AppendPath(job.OutDir, sheet.EnName) + "." + ext

// 开始生成文件
if !job.GenerateByTemplate(&sheet, job.TemplateFile, fullPath) {
job.Log.AddLog(tool.EnumLogType_Error, "生成文件<%s>失败", fullPath)
return
}

tool.EchoOk(" 导出[%s] -> [%s]成功", sheet.CnName, fileName)
// job.Log.AddLog(tool.EnumLogType_Ok, "导出[%s] -> [%s]成功", sheet.CnName, fileName)
}

```

Click here to show extra information the analyzer produced.

```
The following dot graph describes paths through the callgraph that could lead to a function which writes a pointer argument:
no paths found; call may have ended in third-party code; stay tuned for diagnostics
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 7b2c93e51ab5db7649ee30d127dd374af6d6d711

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.