github-vet / github-vet/rangeloop-pointer-findings

Leboudin/go_distributed_object_storage: provider/server.go; 37 LoC

Open
#8,063 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [Leboudin/go_distributed_object_storage](https://www.github.com/Leboudin/go_distributed_object_storage) at [provider/server.go](https://github.com/Leboudin/go_distributed_object_storage/blob/48d0ccbc36bb96af796a9f432e9ba32639fdf567/provider/server.go#L94-L130)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable r used in defer or goroutine at line 108

[Click here to see the code in its original context.](https://github.com/Leboudin/go_distributed_object_storage/blob/48d0ccbc36bb96af796a9f432e9ba32639fdf567/provider/server.go#L94-L130)

Click here to show the 37 line(s) of Go which triggered the analyzer.

```go
for r := range c {
log.Printf("Consume message %s", *r.Body)
req := make(map[string]string)
err := json.Unmarshal([]byte(*r.Body), &req)
if err != nil {
log.Printf("Failed to unmarshal string to JSON, error: %s", err)
continue
}

log.Printf("Trying to located object %s, request UID: %s", req["name"], req["uid"])
if s.isObjectExists(req["name"]) {
log.Printf("Object %s found", req["name"])
// delete the message
go func() {
err := locateSQS.DeleteMessage(r, locateSQS.Url)
if err != nil {
log.Printf("Failed to delete message %s, error: %s", *r.ReceiptHandle, err)
}
}()

// send reply to godos-test-located queue
go func() {
msg := map[string]string{
"name": req["name"],
"uid": req["uid"],
"addr": s.addr,
}

_, err := locateSQS.SendMessage(msg, locateSQS.ReplyUrl)
if err != nil {
log.Printf("Failed to send reply message, error: %s", err)
}
}()
} else {
log.Printf("Object %s not found", req["name"])
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 48d0ccbc36bb96af796a9f432e9ba32639fdf567

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.