github-vet / github-vet/rangeloop-pointer-findings

linuxisnotunix/Vulnerobot: modules/collectors/nvd/nvd.go; 22 LoC

Open
#8,052 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [linuxisnotunix/Vulnerobot](https://www.github.com/linuxisnotunix/Vulnerobot) at [modules/collectors/nvd/nvd.go](https://github.com/linuxisnotunix/Vulnerobot/blob/2177622ad50d919646b4c60f3c1f700a6fa15e48/modules/collectors/nvd/nvd.go#L379-L400)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> function call which takes a reference to cpe at line 384 may start a goroutine

[Click here to see the code in its original context.](https://github.com/linuxisnotunix/Vulnerobot/blob/2177622ad50d919646b4c60f3c1f700a6fa15e48/modules/collectors/nvd/nvd.go#L379-L400)

Click here to show the 22 line(s) of Go which triggered the analyzer.

```go
for _, cpe := range cpes {
log.WithFields(log.Fields{
"cpe": el.Component["CPE"],
}).Infof("%s: Found CPE : %s", id, cpe.ID)
vulns := make([]models.NvdCVE, 0)
db.Orm().Model(&cpe).Association("RelatedCVEs").Find(&vulns)
for _, vuln := range vulns {
log.WithFields(log.Fields{
"cpe": el.Component["CPE"],
}).Debugf("%s: Found Vuln : %s", id, vuln.ID)
resVulns.Add(models.ResponseListVuln{
Source: id,
Value: map[string]string{
"ID": vuln.ID,
"CPE": cpe.ID,
"Summary": vuln.Summary,
"URL": fmt.Sprintf(nvdURLFormat, vuln.ID),
},
})
nbVulns++
}
}

```

Click here to show extra information the analyzer produced.

```
The following dot graph describes paths through the callgraph that could lead to a function calling a goroutine:
no paths found; call may have ended in third-party code; stay tuned for diagnostics
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 2177622ad50d919646b4c60f3c1f700a6fa15e48

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.