github-vet / github-vet/rangeloop-pointer-findings
egonelbre/exp: spec/soap/list.go; 12 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [egonelbre/exp](https://www.github.com/egonelbre/exp) at [spec/soap/list.go](https://github.com/egonelbre/exp/blob/7e1f30e84605dfe55ad9f8a42f5b4b818b6a2c1a/spec/soap/list.go#L57-L68)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> function call at line 67 may store a reference to child
[Click here to see the code in its original context.](https://github.com/egonelbre/exp/blob/7e1f30e84605dfe55ad9f8a42f5b4b818b6a2c1a/spec/soap/list.go#L57-L68)
Click here to show the 12 line(s) of Go which triggered the analyzer.
```go
for i, child := range node.Nodes {
v := items.Index(i)
if v.Kind() == reflect.Ptr && v.IsNil() {
v.Set(reflect.New(v.Type()))
}
if v.Kind() != reflect.Ptr {
v = v.Addr()
}
childspec := v.Interface().(Speced).Spec()
childspec.Decode(&child)
}
```
Click here to show extra information the analyzer produced.
```
The following paths through the callgraph could lead to a function which writes a pointer argument:
no paths found; call ended in third-party code; stay tuned for diagnostics
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 7e1f30e84605dfe55ad9f8a42f5b4b818b6a2c1a
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.