github-vet / github-vet/rangeloop-pointer-findings

nulijiabei/gcpool: pool.go; 19 LoC

Open
#8,037 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [nulijiabei/gcpool](https://www.github.com/nulijiabei/gcpool) at [pool.go](https://github.com/nulijiabei/gcpool/blob/41530301bb79ff5820be246bf33b1fbf66175f73/pool.go#L47-L65)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable streams used in defer or goroutine at line 50

[Click here to see the code in its original context.](https://github.com/nulijiabei/gcpool/blob/41530301bb79ff5820be246bf33b1fbf66175f73/pool.go#L47-L65)

Click here to show the 19 line(s) of Go which triggered the analyzer.

```go
for nm, streams := range this.streams {
go func() {
for {
streams.get(func(stream chan interface{}) {
select {
case content := <-stream: // 接收流的数据并推送
data := content.([2]interface{})
id := data[0].(string)
log.Printf("pool stream(%s) content recv(%s)", nm, id)
this.conns[nm].Get(id, func(conn *websocket.Conn) error {
log.Printf("pool stream(%s) content send(%s)", nm, id)
_, err := conn.Write(append(data[1].([]byte), '\n'))
return err
})
}
})
}
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 41530301bb79ff5820be246bf33b1fbf66175f73

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.