github-vet / github-vet/rangeloop-pointer-findings
mrjdainc/da-inc: library/library.go; 19 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [mrjdainc/da-inc](https://www.github.com/mrjdainc/da-inc) at [library/library.go](https://github.com/mrjdainc/da-inc/blob/29a37647cfa1d093b7245038b4ba53a414aac7b1/library/library.go#L335-L353)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> function call which takes a reference to item at line 351 may start a goroutine
[Click here to see the code in its original context.](https://github.com/mrjdainc/da-inc/blob/29a37647cfa1d093b7245038b4ba53a414aac7b1/library/library.go#L335-L353)
Click here to show the 19 line(s) of Go which triggered the analyzer.
```go
for _, item := range items {
// Remove from dainc's library to prevent duplicates
if item.Type == movieType {
if IsDuplicateMovie(strconv.Itoa(item.ID)) {
if _, err := RemoveMovie(item.ID); err != nil {
log.Warning("Nothing left to remove from dainc")
}
}
} else {
if IsDuplicateEpisode(item.ShowID, item.Season, item.Episode) {
if err := RemoveEpisode(item.ID, item.ShowID, item.Season, item.Episode); err != nil {
log.Warning(err)
}
}
}
database.GetStormDB().DeleteStruct(&item)
log.Infof("Removed %s from database", infoHash)
}
```
Click here to show extra information the analyzer produced.
```
The following paths through the callgraph could lead to a function calling a goroutine:
no paths found; call ended in third-party code; stay tuned for diagnostics
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 29a37647cfa1d093b7245038b4ba53a414aac7b1
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.