github-vet / github-vet/rangeloop-pointer-findings
infinitbyte/gopa: plugins/dispatch/dispatch.go; 44 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [infinitbyte/gopa](https://www.github.com/infinitbyte/gopa) at [plugins/dispatch/dispatch.go](https://github.com/infinitbyte/gopa/blob/9f9c894139be5810924f22c8b0273dcd0380f45a/plugins/dispatch/dispatch.go#L36-L79)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> function call at line 71 may store a reference to v
[Click here to see the code in its original context.](https://github.com/infinitbyte/gopa/blob/9f9c894139be5810924f22c8b0273dcd0380f45a/plugins/dispatch/dispatch.go#L36-L79)
Click here to show the 44 line(s) of Go which triggered the analyzer.
```go
for _, v := range tasks {
log.Trace("get task from db, ", v.ID)
if v.Status == model.TaskPendingFetch {
log.Tracef("task %v alrady in fetch, ingore", v.ID)
continue
}
context := pipeline.Context{}
context.Set(model.CONTEXT_TASK_ID, v.ID)
//update offset
if v.Created.Unix() > offset {
offset = v.Created.Unix()
}
runner := "fetch"
if v.HostConfig == nil && cfg.GetHostConfigByUrl {
//assign pipeline config
config, _ := model.GetHostConfigByHostAndUrl(runner, v.Host, v.Url)
if config != nil {
v.HostConfig = config
context.Set(model.CONTEXT_TASK_Cookies, v.HostConfig.Cookies)
context.Set(model.CONTEXT_TASK_PipelineConfigID, v.HostConfig.PipelineID)
log.Trace("get host config: ", util.ToJson(config, true))
}
}
if v.PipelineConfigID != "" {
context.Set(model.CONTEXT_TASK_PipelineConfigID, v.PipelineConfigID)
}
//Update task status
v.Status = model.TaskPendingFetch
model.UpdateTask(&v)
err := queue.Push(config.FetchChannel, util.ToJSONBytes(context))
log.Trace("push task to fetch queue, ", v.ID)
if err != nil {
log.Error(err)
continue
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 9f9c894139be5810924f22c8b0273dcd0380f45a
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.