github-vet / github-vet/rangeloop-pointer-findings

kushieda-minori/vc_file_grouper: handler/characterhandlers.go; 49 LoC

Open
#7,997 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [kushieda-minori/vc_file_grouper](https://www.github.com/kushieda-minori/vc_file_grouper) at [handler/characterhandlers.go](https://github.com/kushieda-minori/vc_file_grouper/blob/347ba117f85d9a47842278351c35de9f32d377f4/handler/characterhandlers.go#L120-L168)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> function call at line 121 may store a reference to character

[Click here to see the code in its original context.](https://github.com/kushieda-minori/vc_file_grouper/blob/347ba117f85d9a47842278351c35de9f32d377f4/handler/characterhandlers.go#L120-L168)

Click here to show the 49 line(s) of Go which triggered the analyzer.

```go
for _, character := range chars {
if !filter(&character) {
continue
}

card := character.FirstEvoCard()

cardName := "N/A"

if card != nil {
if card.Name == "" {
cardName = card.Image()
} else {
cardName = card.Name
}
}

cardNos := ""
for _, card := range character.Cards() {
if len(cardNos) > 0 {
cardNos = cardNos + ", "
}
cardNos = cardNos + strconv.Itoa(card.CardNo)
}

fmt.Fprintf(w, "%d"+
"%s"+
"%[3]s"+
"%s"+
"%s"+
"%s"+
"%s"+
"%s"+
"%s"+
"%s"+
"%s\n",
character.ID,
cardNos,
cardName,
character.Description,
character.Friendship,
character.Login,
character.Meet,
character.BattleStart,
character.BattleEnd,
character.FriendshipMax,
character.FriendshipEvent,
)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 347ba117f85d9a47842278351c35de9f32d377f4

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.