github-vet / github-vet/rangeloop-pointer-findings

keaaa/k8s-vulnerability-scanner: api/storage.go; 39 LoC

Open
#7,986 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [keaaa/k8s-vulnerability-scanner](https://www.github.com/keaaa/k8s-vulnerability-scanner) at [api/storage.go](https://github.com/keaaa/k8s-vulnerability-scanner/blob/c17caf4608105ebbc955ba5de3a892166278863e/api/storage.go#L184-L222)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable target used in defer or goroutine at line 204

[Click here to see the code in its original context.](https://github.com/keaaa/k8s-vulnerability-scanner/blob/c17caf4608105ebbc955ba5de3a892166278863e/api/storage.go#L184-L222)

Click here to show the 39 line(s) of Go which triggered the analyzer.

```go
for i, target := range image.Targets {
fmt.Printf("Save image")
imageID, err := sqlClient.execSQL(tsql,
sql.Named("imageName", image.Name),
sql.Named("target", target.Target),
sql.Named("runID", runID),
sql.Named("criticalSeverities", target.countBySeverity(Critical)),
sql.Named("highSeverities", target.countBySeverity(High)),
sql.Named("mediumSeverities", target.countBySeverity(Medium)),
sql.Named("lowSeverities", target.countBySeverity(Low)),
sql.Named("unknownSeverities", target.countBySeverity(Unknown)))
if err != nil {
return err
}

var wg sync.WaitGroup
var saveVulErr error
var savePodErr error
wg.Add(2)
go func() {
saveVulErr = sqlClient.saveVulnerabilities(target.Target, imageID, target.Vulnerabilities)
wg.Done()
}()

go func() {
if i == 0 {
savePodErr = sqlClient.savePods(imageID, image.Pods)
}
wg.Done()
}()
wg.Wait()

if savePodErr != nil {
return fmt.Errorf("Failed to save pod %v", savePodErr)
}
if saveVulErr != nil {
return fmt.Errorf("Failed to save vulnerabilities %v", saveVulErr)
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: c17caf4608105ebbc955ba5de3a892166278863e

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.