github-vet / github-vet/rangeloop-pointer-findings

moisespsena-go/xssh: server/proxy.go; 60 LoC

Open
#7,960 0 comments 0 reactions 0 assignees View on GitHub
fresh medium
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [moisespsena-go/xssh](https://www.github.com/moisespsena-go/xssh) at [server/proxy.go](https://github.com/moisespsena-go/xssh/blob/971c0d27c323ad184e10d21a22d274f4fb07eb90/server/proxy.go#L93-L152)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable newChan used in defer or goroutine at line 116

[Click here to see the code in its original context.](https://github.com/moisespsena-go/xssh/blob/971c0d27c323ad184e10d21a22d274f4fb07eb90/server/proxy.go#L93-L152)

Click here to show the 60 line(s) of Go which triggered the analyzer.

```go
for newChan := range chans {
if err := getClient(); err != nil {
newChan.Reject(gossh.ConnectionFailed, err.Error())
return
}
rch, rreqs, err := client.OpenChannel(newChan.ChannelType(), newChan.ExtraData())
if err != nil {
if ocerr, ok := err.(*gossh.OpenChannelError); ok {
newChan.Reject(ocerr.Reason, ocerr.Message)
continue
} else {
newChan.Reject(gossh.ConnectionFailed, "server error: "+err.Error())
return
}
}

ch, reqs, err := newChan.Accept()

go func() {
defer rch.Close()
for req := range rreqs {
ok, err := ch.SendRequest(req.Type, req.WantReply, req.Payload)
if err != nil {
lp("[C < AP: ch="+newChan.ChannelType()+", req="+req.Type+"] send request failed:", err.Error())
}
if req.WantReply {
if err != nil {
err = req.Reply(false, []byte("send to client failed: "+err.Error()))
} else {
err = req.Reply(ok, nil)
}
if err != nil {
lp("[C < AP: ch="+newChan.ChannelType()+", req="+req.Type+"] reply failed:", err.Error())
}
}
}
}()

if err != nil {
conn.Close()
return
}

for req := range reqs {
ok, err := rch.SendRequest(req.Type, req.WantReply, req.Payload)
if err != nil {
lp("[C > AP: ch="+newChan.ChannelType()+", req="+req.Type+"] send request failed:", err.Error())
}
if req.WantReply {
if err != nil {
err = req.Reply(false, []byte("send to client failed: "+err.Error()))
} else {
err = req.Reply(ok, nil)
}
if err != nil {
lp("[C > AP: ch="+newChan.ChannelType()+", req="+req.Type+"] reply failed:", err.Error())
}
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 971c0d27c323ad184e10d21a22d274f4fb07eb90

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.