github-vet / github-vet/rangeloop-pointer-findings
kiali/demos: travels/travel_portal/travel_portal.go; 7 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [kiali/demos](https://www.github.com/kiali/demos) at [travels/travel_portal/travel_portal.go](https://github.com/kiali/demos/blob/2962175921cf519d2939cc0f3f6a1a462006f625/travels/travel_portal/travel_portal.go#L301-L307)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to cr is reassigned at line 303
[Click here to see the code in its original context.](https://github.com/kiali/demos/blob/2962175921cf519d2939cc0f3f6a1a462006f625/travels/travel_portal/travel_portal.go#L301-L307)
Click here to show the 7 line(s) of Go which triggered the analyzer.
```go
for i, cr := range status.Cities {
if cr.City == city {
cityRequest = &cr
iCity = i
break
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 2962175921cf519d2939cc0f3f6a1a462006f625
Contributor guide
No contributing guide indexed for this repository
Research direction
Inspect travels/travel_portal/travel_portal.go at lines 301-307, starting with the range loop and the assignment to cityRequest. Determine whether the analyzer's reported reference reassignment is a bug, mitigated, or desirable behavior, then leave the corresponding reaction on the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 30/100