github-vet / github-vet/rangeloop-pointer-findings
arbaer/dbstream: src/modules/scheduler/scheduler.go; 28 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [arbaer/dbstream](https://www.github.com/arbaer/dbstream) at [src/modules/scheduler/scheduler.go](https://github.com/arbaer/dbstream/blob/6c35b5d918927644288b2469bc626b4cda6f3f3b/src/modules/scheduler/scheduler.go#L240-L267)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to job is reassigned at line 245
[Click here to see the code in its original context.](https://github.com/arbaer/dbstream/blob/6c35b5d918927644288b2469bc626b4cda6f3f3b/src/modules/scheduler/scheduler.go#L240-L267)
Click here to show the 28 line(s) of Go which triggered the analyzer.
```go
for name, job := range s.waitingJobs {
var j *remote.JobExec
j = nil
ser := s.series[name]
if len(ser.inputs) == 0 {
j = &job
} else {
for _, input := range ser.inputs {
t, found := s.getLastInputTime(input.Name)
if !found {
log.Printf("Input %s for jobSeries %s is missing.\n", input.Name, name)
j = nil
break
} else {
if t >= job.InputTime - int64(input.Delay) {
j = &job
} else {
j = nil
break
}
}
}
}
if j != nil {
log.Printf("Adding: %v", *j)
candJobs = append(candJobs, job)
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 6c35b5d918927644288b2469bc626b4cda6f3f3b
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.