github-vet / github-vet/rangeloop-pointer-findings
b4fun/frpcontroller: controllers/endpoint_controller.go; 10 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [b4fun/frpcontroller](https://www.github.com/b4fun/frpcontroller) at [controllers/endpoint_controller.go](https://github.com/b4fun/frpcontroller/blob/38f08f5cc37bbdad3e4d35aead3f8c75595de921/controllers/endpoint_controller.go#L250-L259)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to p is reassigned at line 254
[Click here to see the code in its original context.](https://github.com/b4fun/frpcontroller/blob/38f08f5cc37bbdad3e4d35aead3f8c75595de921/controllers/endpoint_controller.go#L250-L259)
Click here to show the 10 line(s) of Go which triggered the analyzer.
```go
for _, p := range podList.Items {
if len(p.Annotations) > 0 {
configVersion, exists := p.Annotations[annotationKeyEndpointPodConfigVersion]
if exists && configVersion == frpcConfig.ResourceVersion {
pod = &p
logger.Info(fmt.Sprintf("found pod with updated config: %s", p.Name))
break
}
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 38f08f5cc37bbdad3e4d35aead3f8c75595de921
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.