github-vet / github-vet/rangeloop-pointer-findings
b4fun/frpcontroller: controllers/service_controller.go; 21 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [b4fun/frpcontroller](https://www.github.com/b4fun/frpcontroller) at [controllers/service_controller.go](https://github.com/b4fun/frpcontroller/blob/38f08f5cc37bbdad3e4d35aead3f8c75595de921/controllers/service_controller.go#L90-L110)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to kservice is reassigned at line 109
[Click here to see the code in its original context.](https://github.com/b4fun/frpcontroller/blob/38f08f5cc37bbdad3e4d35aead3f8c75595de921/controllers/service_controller.go#L90-L110)
Click here to show the 21 line(s) of Go which triggered the analyzer.
```go
for _, kservice := range kserviceList.Items {
kservice.Spec.Selector = service.Spec.Selector
kservice.Spec.Ports = nil
for _, port := range service.Spec.Ports {
kservice.Spec.Ports = append(kservice.Spec.Ports, port.ToCorev1ServicePort())
}
if len(service.Spec.ServiceLabels) > 0 {
// NOTE: reset all previous labels
kservice.Labels = map[string]string{}
for k, v := range service.Spec.ServiceLabels {
kservice.Labels[k] = v
}
}
err = r.Update(ctx, &kservice)
if err != nil {
logger.Error(err, fmt.Sprintf("update corev1.service %s failed", service.Name))
return ctrl.Result{}, err
}
logger.Info(fmt.Sprintf("updated corev1.service: %s", kservice.Name))
kserviceBound = &kservice
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 38f08f5cc37bbdad3e4d35aead3f8c75595de921
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.