github-vet / github-vet/rangeloop-pointer-findings
jonreyna/JChecker: main.go; 36 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [jonreyna/JChecker](https://www.github.com/jonreyna/JChecker) at [main.go](https://github.com/jonreyna/JChecker/blob/a8418908892c55819e331e31f616beeba56b1caa/main.go#L104-L139)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable cmd used in defer or goroutine at line 123
[Click here to see the code in its original context.](https://github.com/jonreyna/JChecker/blob/a8418908892c55819e331e31f616beeba56b1caa/main.go#L104-L139)
Click here to show the 36 line(s) of Go which triggered the analyzer.
```go
for _, cmd := range cmds {
replyChan, errChan := reply.ProcessChassisEnv(cmd.Run())
go func() {
const thisFunc = "main.runCommands.func()"
cntxLog := log.WithFields(log.Fields{
"func": thisFunc,
})
defer wg.Done()
done := false
for !done {
select {
case r, ok := <-replyChan:
if !ok {
cntxLog.Debugln("replyChan closed")
done = true
break
} else if outFile, err := cmd.OutFile(); err != nil {
cntxLog.Errorln(err)
} else if err := r.WriteCSV(outFile); err != nil {
cntxLog.Errorln(err)
}
case e, ok := <-errChan:
if !ok {
cntxLog.Debugln("errChan closed")
done = true
break
} else {
log.Errorln(e)
}
}
}
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: a8418908892c55819e331e31f616beeba56b1caa
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.