github-vet / github-vet/rangeloop-pointer-findings

tkestack/galaxy: pkg/network/vlan/vlan.go; 20 LoC

Open
#7,764 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [tkestack/galaxy](https://www.github.com/tkestack/galaxy) at [pkg/network/vlan/vlan.go](https://github.com/tkestack/galaxy/blob/7f274b175a358d981341bb46cba1cdb794bc69a6/pkg/network/vlan/vlan.go#L190-L209)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable i used in defer or goroutine at line 197

[Click here to see the code in its original context.](https://github.com/tkestack/galaxy/blob/7f274b175a358d981341bb46cba1cdb794bc69a6/pkg/network/vlan/vlan.go#L190-L209)

Click here to show the 20 line(s) of Go which triggered the analyzer.

```go
for i := range filteredAddr {
if err = netlink.AddrDel(device, &filteredAddr[i]); err != nil {
return fmt.Errorf("failed to remove v4address from device %s: %v", d.Device, err)
}
// nolint: errcheck
defer func() {
if err != nil {
netlink.AddrAdd(device, &filteredAddr[i])
}
}()
filteredAddr[i].Label = ""
if err = netlink.AddrAdd(bri, &filteredAddr[i]); err != nil {
if !strings.Contains(err.Error(), "file exists") {
return fmt.Errorf("failed to add v4address to bridge device %s: %v, address %v", d.DefaultBridgeName,
err, filteredAddr[i])
} else {
err = nil
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 7f274b175a358d981341bb46cba1cdb794bc69a6

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.