github-vet / github-vet/rangeloop-pointer-findings

thomasmodeneis/twittbid: twittbid/twitter.go; 39 LoC

Open
#7,710 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [thomasmodeneis/twittbid](https://www.github.com/thomasmodeneis/twittbid) at [twittbid/twitter.go](https://github.com/thomasmodeneis/twittbid/blob/46032ffa97c240405a79e09d934f2f5902f0bd60/twittbid/twitter.go#L42-L80)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable q used in defer or goroutine at line 63

[Click here to see the code in its original context.](https://github.com/thomasmodeneis/twittbid/blob/46032ffa97c240405a79e09d934f2f5902f0bd60/twittbid/twitter.go#L42-L80)

Click here to show the 39 line(s) of Go which triggered the analyzer.

```go
for q := range t.queryQueue {
url := q.url
form := q.form
data := q.data
method := q.method

responseCh := q.responseCh

if t.bucket != nil {
<-t.bucket.SpendToken(1)
}

err := t.performQuery(url, form, data, method)

// check for rate-limiting error
if err != nil {
if apiErr, ok := err.(*APIError); ok {
if isRateLimitError, nextWindow := apiErr.CheckRateLimit(); isRateLimitError && !t.returnRateLimitError {
log.Fatal(apiErr.Error())

go func() {
t.queryQueue <- q
}()

delay := nextWindow.Sub(time.Now())
<-time.After(delay)

// clean bucket
if t.bucket != nil {
t.bucket.Drain()
}

continue
}
}
}

responseCh <- Response{data, err}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 46032ffa97c240405a79e09d934f2f5902f0bd60

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.