github-vet / github-vet/rangeloop-pointer-findings
theanalyst/rlyeh: main.go; 23 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [theanalyst/rlyeh](https://www.github.com/theanalyst/rlyeh) at [main.go](https://github.com/theanalyst/rlyeh/blob/e4199c9cebb0103d6d48170ed83eed3e33bb4d3e/main.go#L45-L67)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable osd_socket used in defer or goroutine at line 47
[Click here to see the code in its original context.](https://github.com/theanalyst/rlyeh/blob/e4199c9cebb0103d6d48170ed83eed3e33bb4d3e/main.go#L45-L67)
Click here to show the 23 line(s) of Go which triggered the analyzer.
```go
for _, osd_socket := range osd_sockets {
go func() {
result, err := QueryAdminSocket(osd_socket)
if err != nil {
log.Fatal("Querying Socket failed with ", err)
}
c <- perf{*result, err}
}()
query := <-c
if query.error == nil {
perfcounters = append(perfcounters, query.PerfCounter)
// perf_json, err := json.Marshal(query.PerfCounter)
// if err == nil {
// fmt.Println(string(perf_json))
// }
token, err := get_token()
if err == nil {
PostPerfCeilometer(token, query.PerfCounter)
}
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: e4199c9cebb0103d6d48170ed83eed3e33bb4d3e
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.