github-vet / github-vet/rangeloop-pointer-findings

sarahc0nn0r/ultranet: backend/lib/server.go; 11 LoC

Open
#7,565 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [sarahc0nn0r/ultranet](https://www.github.com/sarahc0nn0r/ultranet) at [backend/lib/server.go](https://github.com/sarahc0nn0r/ultranet/blob/45bb70e1d26173e7427c0eedbfb7c8d0d37d4837/backend/lib/server.go#L450-L460)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable listingsToFetch used in defer or goroutine at line 455

[Click here to see the code in its original context.](https://github.com/sarahc0nn0r/ultranet/blob/45bb70e1d26173e7427c0eedbfb7c8d0d37d4837/backend/lib/server.go#L450-L460)

Click here to show the 11 line(s) of Go which triggered the analyzer.

```go
for peerID, listingsToFetch := range peerIDToListingHashes {
peerToFetchFrom := peerIDToPeer[peerID]

// Queue a request for the listings from the corresponding peer.
go func() {
peerToFetchFrom.PushGetListingsMsg(listingsToFetch)
}()

glog.Debugf("GetListings: Downloading %d listings from peer %v",
len(listingsToFetch), peerToFetchFrom)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 45bb70e1d26173e7427c0eedbfb7c8d0d37d4837

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.