github-vet / github-vet/rangeloop-pointer-findings

userfm99/zuuly: zuuly.go; 35 LoC

Open
#7,529 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [userfm99/zuuly](https://www.github.com/userfm99/zuuly) at [zuuly.go](https://github.com/userfm99/zuuly/blob/e75cd11971dc6f625a8f48e2b5a0b11ae365b765/zuuly.go#L97-L131)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to k is reassigned at line 98

[Click here to see the code in its original context.](https://github.com/userfm99/zuuly/blob/e75cd11971dc6f625a8f48e2b5a0b11ae365b765/zuuly.go#L97-L131)

Click here to show the 35 line(s) of Go which triggered the analyzer.

```go
for k, v := range propertySources {
if key = &k; filterKeyFunc != nil {
key = filterKeyFunc(&k)
}
if key != nil {
if strings.HasSuffix(*key, ".url") {
*key = strings.Replace(*key, ".url", "", 1)
u, _ := url.Parse(zuulURL(v.(string), propertySources))
if zr, ok := zuulRoutes[*key]; ok {
zr.ReverseProxyBaseURL = u.Host
zr.ReverseProxyScheme = u.Scheme
zr.ReverseProxyPath = u.Path
zuulRoutes[*key] = zr
} else {
zuulRoutes[*key] = ZuulRoute{
ReverseProxyBaseURL: u.Host,
ReverseProxyScheme: u.Scheme,
ReverseProxyPath: u.Path,
}
}
} else if strings.HasSuffix(k, ".path") {
*key = strings.Replace(*key, ".path", "", 1)
strVal := v.(string)
strVal = strings.Replace(strVal, "/**", "/*", 1)
if zr, ok := zuulRoutes[*key]; ok {
zr.FrontPath = strVal
zuulRoutes[*key] = zr
} else {
zuulRoutes[*key] = ZuulRoute{
FrontPath: strVal,
}
}
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: e75cd11971dc6f625a8f48e2b5a0b11ae365b765

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.