github-vet / github-vet/rangeloop-pointer-findings
cisco-sso/snapshot-manager: pkg/manager/validator.go; 3 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [cisco-sso/snapshot-manager](https://www.github.com/cisco-sso/snapshot-manager) at [pkg/manager/validator.go](https://github.com/cisco-sso/snapshot-manager/blob/6a8a225dbd9701bc8a417e22fb65d82fc5fb8eaf/pkg/manager/validator.go#L162-L164)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> function call which takes a reference to claim at line 163 may start a goroutine
[Click here to see the code in its original context.](https://github.com/cisco-sso/snapshot-manager/blob/6a8a225dbd9701bc8a417e22fb65d82fc5fb8eaf/pkg/manager/validator.go#L162-L164)
Click here to show the 3 line(s) of Go which triggered the analyzer.
```go
for _, claim := range run.Spec.Objects.Claims {
v.kube.DeletePVC(&claim)
}
```
Click here to show extra information the analyzer produced.
```
The following paths through the callgraph could lead to a goroutine:
(DeletePVC, 1) -> (Get, 1) -> (readAny, 0) -> (New, 1) -> (Keys, 1) -> (KeysPrefix, 2)
(DeletePVC, 1) -> (Get, 1) -> (Remove, 1) -> (removeElement, 1) -> (Keys, 1) -> (KeysPrefix, 2) -> (walker, 3)
(DeletePVC, 1) -> (Get, 1) -> (String, 0) -> (Error, 0) -> (init, 1) -> (init, 0) -> (NewDefaultingCodecForScheme, 5) -> (UnsafeObjectConvertor, 1)
(DeletePVC, 1) -> (Get, 1) -> (NewNotFound, 2) -> (String, 0) -> (Sort, 1) -> (sort, 1) -> (Bytes, 2) -> (doAppend, 4) -> (poller, 2)
(DeletePVC, 1) -> (Get, 1) -> (get, 1) -> (sinceInMicroseconds, 1) -> (ConfigureTransport, 1) -> (configureTransport, 1) -> (addConnIfNeeded, 3) -> (run, 3) -> (NewClientConn, 1) -> (newClientConn, 2) -> (readLoop, 0) -> (WriteGoAway, 3) -> (writeBytes, 1) -> (FilterFunc, 1) -> (resetOrReuseTimer, 3)
(DeletePVC, 1) -> (Get, 1) -> (String, 0) -> (Error, 0) -> (init, 1) -> (init, 0)
(DeletePVC, 1) -> (Get, 1) -> (Read, 1) -> (Err, 0) -> (Encode, 2) -> (ConvertToVersion, 2) -> (convertToVersion, 3)
(DeletePVC, 1) -> (Get, 1) -> (Read, 1) -> (Err, 0) -> (Keys, 1) -> (KeysPrefix, 2) -> (walker, 3)
(DeletePVC, 1) -> (Get, 1) -> (String, 0) -> (Error, 0) -> (printf, 3) -> (output, 5) -> (AddInt64, 2)
(DeletePVC, 1) -> (Get, 1) -> (get, 1) -> (sinceInMicroseconds, 1) -> (ConfigureTransport, 1) -> (configureTransport, 1) -> (addConnIfNeeded, 3) -> (run, 3) -> (NewClientConn, 1) -> (newClientConn, 2) -> (readLoop, 0) -> (WriteGoAway, 3) -> (writeBytes, 1) -> (FilterFunc, 1)
(DeletePVC, 1) -> (Get, 1) -> (New, 1) -> (newFileLoaderAt, 4) -> (parse, 0) -> (consume, 1)
(DeletePVC, 1) -> (Get, 1) -> (Read, 1) -> (Err, 0) -> (, 0) -> (Package, 1) -> (Stat, 1)
(DeletePVC, 1) -> (Delete, 2) -> (Do, 0) -> (transformResponse, 2) -> (, 0) -> (Package, 1) -> (currentMigrationRules, 0) -> (pow10Int64, 1)
(DeletePVC, 1) -> (Get, 1) -> (Remove, 1) -> (removeElement, 1) -> (Sort, 1) -> (sort, 1) -> (Bytes, 2) -> (doAppend, 4) -> (poller, 2)
(DeletePVC, 1) -> (Get, 1) -> (New, 1) -> (newFileLoaderAt, 4) -> (KeysPrefix, 2)
(DeletePVC, 1) -> (Get, 1) -> (New, 1) -> (newFileLoaderAt, 4) -> (init, 1) -> (init, 0)
(DeletePVC, 1) -> (Get, 1) -> (NewNotFound, 2) -> (String, 0) -> (Write, 1) -> (PutUint32, 2) -> (logf, 3) -> (cloneHeader, 1)
(DeletePVC, 1) -> (Get, 1) -> (Interface, 0) -> (errSyntax, 0) -> (Sort, 1) -> (sort, 1) -> (Bytes, 2) -> (doAppend, 4) -> (poller, 2)
(DeletePVC, 1) -> (Get, 1) -> (Read, 1) -> (Err, 0) -> (parse, 0) -> (consume, 1)
(DeletePVC, 1) -> (Delete, 2) -> (Body, 1) -> (SetHeader, 2) -> (NewEncoder, 1) -> (newEncoderWithWriter, 1)
(DeletePVC, 1) -> (Get, 1) -> (Read, 1) -> (Err, 0) -> (Decode, 1) -> (LastIndex, 2) -> (NewYAMLReader, 1)
(DeletePVC, 1) -> (Get, 1) -> (readAny, 0) -> (New, 1) -> (Sort, 1) -> (sort, 1) -> (Bytes, 2) -> (doAppend, 4) -> (poller, 2)
(DeletePVC, 1) -> (Get, 1) -> (Read, 1) -> (Err, 0) -> (printWithFileLine, 5) -> (output, 5) -> (AddInt64, 2)
(DeletePVC, 1) -> (Get, 1) -> (String, 0) -> (Error, 0) -> (printWithFileLine, 5) -> (output, 5) -> (AddInt64, 2)
(DeletePVC, 1) -> (Delete, 2) -> (Error, 0) -> (NewAggregate, 1) -> (printf, 3) -> (output, 5) -> (AddInt64, 2)
(DeletePVC, 1) -> (Get, 1) -> (Read, 1) -> (Err, 0) -> (, 0) -> (Package, 1) -> (Stat, 1) -> (SetInt64, 1)
(DeletePVC, 1) -> (Get, 1) -> (get, 1) -> (sinceInMicroseconds, 1) -> (ConfigureTransport, 1) -> (configureTransport, 1)
(DeletePVC, 1) -> (Get, 1) -> (keyToFilename, 1) -> (Sum, 1) -> (NewNamed, 1) -> (newQueueMetrics, 2)
(DeletePVC, 1) -> (Get, 1) -> (Remove, 1) -> (removeElement, 1) -> (Keys, 1) -> (KeysPrefix, 2)
(DeletePVC, 1) -> (Get, 1) -> (String, 0) -> (Error, 0) -> (Key, 2) -> (attrKey, 2)
(DeletePVC, 1) -> (Delete, 2) -> (Do, 0) -> (transformResponse, 2) -> (WithTimeout, 2) -> (WithDeadline, 2) -> (AfterFunc, 2) -> (Stop, 0)
(DeletePVC, 1) -> (Get, 1) -> (Read, 1) -> (Err, 0) -> (Sort, 1) -> (sort, 1) -> (Bytes, 2) -> (doAppend, 4) -> (poller, 2)
(DeletePVC, 1) -> (Get, 1) -> (get, 1) -> (sinceInMicroseconds, 1) -> (ConfigureTransport, 1) -> (configureTransport, 1) -> (addConnIfNeeded, 3) -> (run, 3) -> (NewClientConn, 1) -> (newClientConn, 2)
(DeletePVC, 1) -> (Get, 1) -> (get, 1) -> (sinceInMicroseconds, 1) -> (ConfigureTransport, 1) -> (configureTransport, 1) -> (addConnIfNeeded, 3) -> (run, 3) -> (NewClientConn, 1) -> (newClientConn, 2) -> (readLoop, 0) -> (WriteGoAway, 3) -> (writeBytes, 1)
(DeletePVC, 1) -> (Get, 1) -> (NewNotFound, 2) -> (String, 0) -> (WriteString, 1) -> (IsPrint, 1) -> (output, 5) -> (AddInt64, 2)
(DeletePVC, 1) -> (Get, 1) -> (New, 1) -> (newFileLoaderAt, 4) -> (init, 1) -> (init, 0) -> (NewDefaultingCodecForScheme, 5) -> (UnsafeObjectConvertor, 1)
(DeletePVC, 1) -> (Get, 1) -> (Read, 1) -> (Err, 0) -> (Keys, 1) -> (KeysPrefix, 2)
(DeletePVC, 1) -> (Get, 1) -> (NewNotFound, 2) -> (String, 0) -> (Sort, 1) -> (sort, 1) -> (Bytes, 2)
(DeletePVC, 1) -> (Get, 1) -> (Read, 1) -> (Err, 0) -> (parse, 1) -> (internalSelector, 1) -> (consume, 1)
(DeletePVC, 1) -> (Delete, 2) -> (Do, 0) -> (transformResponse, 2) -> (WithTimeout, 2) -> (WithDeadline, 2) -> (AfterFunc, 2)
(DeletePVC, 1) -> (Get, 1) -> (get, 1) -> (sinceInMicroseconds, 1) -> (ConfigureTransport, 1) -> (configureTransport, 1) -> (addConnIfNeeded, 3)
(DeletePVC, 1) -> (Get, 1) -> (Read, 1) -> (Err, 0) -> (Sort, 1) -> (sort, 1) -> (Bytes, 2)
(DeletePVC, 1) -> (Get, 1) -> (readAny, 0) -> (New, 1) -> (Keys, 1) -> (KeysPrefix, 2) -> (walker, 3)
(DeletePVC, 1) -> (Get, 1) -> (Read, 1) -> (Err, 0)
(DeletePVC, 1) -> (Get, 1) -> (New, 1) -> (newFileLoaderAt, 4) -> (KeysPrefix, 2) -> (walker, 3)
(DeletePVC, 1) -> (Get, 1) -> (New, 1) -> (newFileLoaderAt, 4) -> (Key, 2) -> (attrKey, 2)
(DeletePVC, 1) -> (Get, 1) -> (get, 2) -> (Fatalf, 3) -> (printf, 3) -> (output, 5) -> (AddInt64, 2)
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 6a8a225dbd9701bc8a417e22fb65d82fc5fb8eaf
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.