github-vet / github-vet/rangeloop-pointer-findings
ricktian1226/BatteryRun: MazeServer2.0.0/gocode/src/guanghuan.com/xiaoyao/battery_mmo_server/test/client.go; 15 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [ricktian1226/BatteryRun](https://www.github.com/ricktian1226/BatteryRun) at [MazeServer2.0.0/gocode/src/guanghuan.com/xiaoyao/battery_mmo_server/test/client.go](https://github.com/ricktian1226/BatteryRun/blob/c5176485339a69271b83a23982801a67b443c7c1/MazeServer2.0.0/gocode/src/guanghuan.com/xiaoyao/battery_mmo_server/test/client.go#L48-L62)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> function call which takes a reference to msg at line 52 may start a goroutine
[Click here to see the code in its original context.](https://github.com/ricktian1226/BatteryRun/blob/c5176485339a69271b83a23982801a67b443c7c1/MazeServer2.0.0/gocode/src/guanghuan.com/xiaoyao/battery_mmo_server/test/client.go#L48-L62)
Click here to show the 15 line(s) of Go which triggered the analyzer.
```go
for msg := range c.inqueue {
xylogs.Debug("go#1 Get inbound msg : %v", msg)
switch (xymmopb.CMD_CODE)(msg.Cmd) {
case xymmopb.CMD_CODE_CMD_S_GenerateUid:
c.processGenerateUid(&msg)
case xymmopb.CMD_CODE_CMD_S_GameStart:
c.processGameStart(&msg)
case xymmopb.CMD_CODE_CMD_S_Action:
c.processActions(&msg)
case xymmopb.CMD_CODE_CMD_S_GameOver:
c.processGameOver()
default:
xylogs.Error("Unkown CMD %d ", msg.Cmd)
}
}
```
Click here to show extra information the analyzer produced.
```
The following paths through the callgraph could lead to a goroutine:
(processGenerateUid, 1) -> (Error, 2) -> (New, 1) -> (Stack, 0) -> (, 0) -> (NewServerConfig, 0) -> (LastIndex, 2)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (WriteMsg, 2) -> (SendMail, 5) -> (DoRotate, 0) -> (deleteOldLog, 0) -> (closeConnection, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (Init, 0) -> (Error, 3) -> (Log, 3) -> (Warn, 2) -> (initClient, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (readDocTo, 1) -> (IsValid, 0) -> (readElemTo, 2) -> (Parse, 1) -> (Add, 2) -> (GetFlags, 0) -> (processSlowConsumer, 1)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (readDocTo, 1) -> (IsValid, 0) -> (readElemTo, 2) -> (Parse, 1) -> (Add, 2) -> (GetFlags, 0) -> (processOpErr, 1) -> (processDisconnect, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (Init, 0) -> (Error, 3) -> (Log, 3) -> (Warn, 2) -> (DialWithInfo, 1) -> (Ping, 0) -> (SetSafe, 1) -> (ensureSafe, 1) -> (logf, 1) -> (add, 1)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (readDocTo, 1) -> (IsValid, 0) -> (handleSignals, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (readDocTo, 1) -> (IsValid, 0) -> (readAtLeastOneByte, 2) -> (Read, 1) -> (getChunk, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (WriteMsg, 2) -> (SendMail, 5) -> (DoRotate, 0) -> (deleteOldLog, 0) -> (processOpErr, 1) -> (processDisconnect, 0) -> (doReconnect, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (Init, 0) -> (Error, 3) -> (Log, 3) -> (Warn, 2) -> (DialWithInfo, 1) -> (Ping, 0) -> (SetSafe, 1) -> (ensureSafe, 1)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (Init, 0) -> (Error, 3) -> (Log, 3) -> (Warn, 2) -> (subscribe, 4)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (readDocTo, 1) -> (IsValid, 0) -> (Parse, 1) -> (Add, 2) -> (Log, 3) -> (Warn, 2) -> (processReconnect, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (WriteMsg, 2) -> (SendMail, 5) -> (DoRotate, 0) -> (deleteOldLog, 0) -> (processOpErr, 1) -> (processDisconnect, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (Init, 0) -> (Error, 3) -> (Log, 3) -> (Warn, 2) -> (DialWithInfo, 1) -> (Ping, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (Init, 0) -> (Error, 3) -> (Log, 3) -> (Warn, 2) -> (createRoute, 2) -> (setAuthTimer, 1)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (Init, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (Next, 0) -> (run, 0) -> (tarjanSort, 1) -> (idList, 1)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (WriteMsg, 2) -> (SendMail, 5) -> (DoRotate, 0) -> (deleteOldLog, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (Next, 0) -> (run, 0) -> (tarjanSort, 1) -> (idList, 1) -> (closeConnection, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (Init, 0) -> (Error, 3) -> (Log, 3)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (New, 1) -> (Stack, 0) -> (, 0) -> (NewServerConfig, 0) -> (LastIndex, 2)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (readDocTo, 1) -> (IsValid, 0) -> (Parse, 1) -> (Add, 2) -> (Log, 3) -> (Warn, 2)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (Init, 0) -> (Error, 3) -> (Log, 3) -> (Warn, 2) -> (ConnectAndWrite, 2)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (UnmarshalMerge, 2) -> (NewBuffer, 1) -> (readElemTo, 2) -> (Parse, 1) -> (Add, 2) -> (GetFlags, 0) -> (processSlowConsumer, 1)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (readDocTo, 1) -> (IsValid, 0) -> (Parse, 1) -> (Add, 2) -> (Log, 3) -> (Warn, 2) -> (processReconnect, 0) -> (doReconnect, 0)
(processGenerateUid, 1) -> (Error, 2) -> (New, 1) -> (Stack, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (Query, 1) -> (Write, 1)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (handleErr, 1) -> (New, 1) -> (handleSignals, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (Next, 0) -> (run, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (WriteMsg, 2) -> (SendMail, 5) -> (DoRotate, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (UnmarshalMerge, 2) -> (NewBuffer, 1) -> (readElemTo, 2) -> (Parse, 1) -> (Add, 2) -> (GetFlags, 0) -> (processOpErr, 1) -> (processDisconnect, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (UnmarshalMerge, 2) -> (NewBuffer, 1) -> (readElemTo, 2) -> (Parse, 1) -> (Add, 2) -> (GetFlags, 0) -> (processOpErr, 1) -> (processDisconnect, 0) -> (doReconnect, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (readDocTo, 1) -> (IsValid, 0) -> (readElemTo, 2) -> (Parse, 1) -> (Add, 2) -> (GetFlags, 0) -> (processOpErr, 1) -> (processDisconnect, 0) -> (doReconnect, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (New, 1) -> (Stack, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (close, 2)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (Do, 2) -> (ProcessMsg, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (Do, 2) -> (ProcessMsg, 0) -> (protoErr, 3) -> (protoSnippet, 2)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (Init, 0) -> (Error, 3) -> (Log, 3) -> (Warn, 2)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (acquireSocket, 0) -> (socketLogin, 1) -> (Login, 1) -> (loginSASL, 1)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (readDocTo, 1) -> (IsValid, 0) -> (readElemTo, 2) -> (Parse, 1) -> (Add, 2) -> (GetFlags, 0) -> (closeConnection, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (readDocTo, 1) -> (IsValid, 0) -> (Parse, 1) -> (Add, 2) -> (Log, 3) -> (Warn, 2) -> (closeConnection, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (insertChunk, 1)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (readDocTo, 1) -> (IsValid, 0) -> (Get, 1)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (, 0) -> (NewServerConfig, 0) -> (LastIndex, 2)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (readDocTo, 1) -> (IsValid, 0) -> (Get, 1) -> (Hash, 1) -> (NewConfig, 2) -> (ParseRequestURI, 1)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (UnmarshalMerge, 2) -> (NewBuffer, 1) -> (readElemTo, 2) -> (Parse, 1) -> (Add, 2) -> (GetFlags, 0) -> (closeConnection, 0)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (Init, 0) -> (Error, 3)
(processGenerateUid, 1) -> (Unmarshal, 2) -> (Reset, 0) -> (Close, 0) -> (Next, 0) -> (run, 0) -> (tarjanSort, 1)
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: c5176485339a69271b83a23982801a67b443c7c1
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.