github-vet / github-vet/rangeloop-pointer-findings
egnyte/ax: pkg/backend/docker/client.go; 19 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [egnyte/ax](https://www.github.com/egnyte/ax) at [pkg/backend/docker/client.go](https://github.com/egnyte/ax/blob/2c2d4e04cf5cea1a38b282438bbdd0fdc467aa1f/pkg/backend/docker/client.go#L42-L60)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable containerName used in defer or goroutine at line 52
[Click here to see the code in its original context.](https://github.com/egnyte/ax/blob/2c2d4e04cf5cea1a38b282438bbdd0fdc467aa1f/pkg/backend/docker/client.go#L42-L60)
Click here to show the 19 line(s) of Go which triggered the analyzer.
```go
for _, containerName := range GetRunningContainers(client.containerPattern) {
command := []string{"docker", "logs", "--tail", fmt.Sprintf("%d", query.MaxResults)}
if query.Follow {
command = append(command, "-f")
}
command = append(command, containerName)
client := subprocess.New(command)
runningCommands++
go func() {
for message := range client.Query(ctx, query) {
message.Attributes["@container"] = containerName
resultChan <- message
}
runningCommands--
if runningCommands == 0 {
close(resultChan)
}
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 2c2d4e04cf5cea1a38b282438bbdd0fdc467aa1f
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.