github-vet / github-vet/rangeloop-pointer-findings
ochinchina/thriftproxy: main.go; 3 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [ochinchina/thriftproxy](https://www.github.com/ochinchina/thriftproxy) at [main.go](https://github.com/ochinchina/thriftproxy/blob/3bee6a8885cbed94ff2fa40b1ac54be6f68dcb3b/main.go#L118-L120)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> function call which takes a reference to backend at line 119 may start a goroutine
[Click here to see the code in its original context.](https://github.com/ochinchina/thriftproxy/blob/3bee6a8885cbed94ff2fa40b1ac54be6f68dcb3b/main.go#L118-L120)
Click here to show the 3 line(s) of Go which triggered the analyzer.
```go
for _, backend := range proxy.Backends {
roundRobin.AddBackend(&backend)
}
```
Click here to show extra information the analyzer produced.
```
The following paths through the callgraph could lead to a goroutine:
(AddBackend, 1) -> (NewBackend, 1) -> (NewTcpBackend, 1)
(AddBackend, 1) -> (NewBackend, 1) -> (NewTcpBackend, 1) -> (cleanTimeoutResponse, 0)
(AddBackend, 1) -> (NewBackend, 1) -> (NewTcpBackend, 1) -> (cleanTimeoutResponse, 0) -> (start, 0)
(AddBackend, 1) -> (NewBackend, 1) -> (NewTcpBackend, 1) -> (cleanTimeoutResponse, 0) -> (start, 0) -> (Sleep, 1)
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 3bee6a8885cbed94ff2fa40b1ac54be6f68dcb3b
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.