github-vet / github-vet/rangeloop-pointer-findings

openeuler-mirror/cve-manager: taskhandler/cve.go; 25 LoC

Open
#7,428 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [openeuler-mirror/cve-manager](https://www.github.com/openeuler-mirror/cve-manager) at [taskhandler/cve.go](https://github.com/openeuler-mirror/cve-manager/blob/3969de286f48f77a2b152bab4930a7cc013c461d/taskhandler/cve.go#L1746-L1770)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable cveOrg used in defer or goroutine at line 1766

[Click here to see the code in its original context.](https://github.com/openeuler-mirror/cve-manager/blob/3969de286f48f77a2b152bab4930a7cc013c461d/taskhandler/cve.go#L1746-L1770)

Click here to show the 25 line(s) of Go which triggered the analyzer.

```go
for i, cveOrg := range gs {
count = count + 1
logs.Info("当前正常解析第: ", count, "条数据,i:", i, ", cvenum: ", cveOrg.IssueId)
// add mutex
lockOk := models.LockUpdateCveIssueStatus(15, cveOrg.Id)
if !lockOk {
logs.Error("Data is being processed, id: ", cveOrg.Id, ",cveOrg: ", cveOrg)
ch <- i
continue
}
if cveOrg.CveNumber == "" || len(cveOrg.CveNumber) == 0 {
logs.Error("数据异常, 不处理, cveData: ", cveOrg)
models.UpdateCveIssueStatusById(3, cveOrg.Id)
ch <- i
continue
}
go func(idx int, cveData models.GiteOriginIssue) {
ok, err := GenCveVulerByIssue(cveData, cveRef, openeulernum, owner)
if !ok {
logs.Error("GenCveVulerByIssue, cveData: ", cveData, "处理失败, err: ", err)
models.UpdateCveIssueStatusById(3, cveOrg.Id)
}
ch <- idx
}(i, cveOrg)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 3969de286f48f77a2b152bab4930a7cc013c461d

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.