github-vet / github-vet/rangeloop-pointer-findings
kasvith/hackerrank-dl: main.go; 28 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [kasvith/hackerrank-dl](https://www.github.com/kasvith/hackerrank-dl) at [main.go](https://github.com/kasvith/hackerrank-dl/blob/42b1a70a0e67df9bbc2b7b94290edef577fa89e7/main.go#L110-L137)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable q used in defer or goroutine at line 133
[Click here to see the code in its original context.](https://github.com/kasvith/hackerrank-dl/blob/42b1a70a0e67df9bbc2b7b94290edef577fa89e7/main.go#L110-L137)
Click here to show the 28 line(s) of Go which triggered the analyzer.
```go
for q, submissionMap := range subs {
log.Infof("preparing download %d submissions for %s", len(submissionMap), q)
for _, submission := range submissionMap {
wg.Add(1)
go func(qs string, s Submission) {
defer wg.Done()
// wait for the rate limiter
rate <- struct{}{}
// check the concurrency semaphore
semaphore <- struct{}{}
defer func() {
<-semaphore
}()
ds, err := DownloadSubmission(client, cfg, &s)
if err != nil {
log.Errorf("error downloading, ", err)
}
saveChan <- SaveFileRequest{
s: ds,
q: qs,
}
}(q, submission)
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 42b1a70a0e67df9bbc2b7b94290edef577fa89e7
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.