github-vet / github-vet/rangeloop-pointer-findings

pchain-org/pchain: chain/chain_mgr.go; 8 LoC

Open
#7,375 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [pchain-org/pchain](https://www.github.com/pchain-org/pchain) at [chain/chain_mgr.go](https://github.com/pchain-org/pchain/blob/9d1a52693793f5ffa94f41fa02a0255b390ee5a6/chain/chain_mgr.go#L446-L453)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable child used in defer or goroutine at line 448

[Click here to see the code in its original context.](https://github.com/pchain-org/pchain/blob/9d1a52693793f5ffa94f41fa02a0255b390ee5a6/chain/chain_mgr.go#L446-L453)

Click here to show the 8 line(s) of Go which triggered the analyzer.

```go
for _, child := range cm.childChains {
go func() {
childChainError := child.EthNode.Close()
if childChainError != nil {
log.Error("Error when closing child chain", "child id", child.Id, "err", childChainError)
}
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 9d1a52693793f5ffa94f41fa02a0255b390ee5a6

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.