github-vet / github-vet/rangeloop-pointer-findings
ovh/cds: engine/api/workflow/workflow_run_event.go; 17 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [ovh/cds](https://www.github.com/ovh/cds) at [engine/api/workflow/workflow_run_event.go](https://github.com/ovh/cds/blob/56af877c7efa9dabf3a12147d7ae8e1caa6d69db/engine/api/workflow/workflow_run_event.go#L70-L86)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to n is reassigned at line 82
[Click here to see the code in its original context.](https://github.com/ovh/cds/blob/56af877c7efa9dabf3a12147d7ae8e1caa6d69db/engine/api/workflow/workflow_run_event.go#L70-L86)
Click here to show the 17 line(s) of Go which triggered the analyzer.
```go
for _, n := range wr.Workflow.Notifications {
if n.Type != sdk.VCSUserNotification {
continue
}
// If list of node is nill, send notification to all of them
if len(n.NodeIDs) == 0 {
notif = &n
break
}
// browser source node id
for _, src := range n.NodeIDs {
if src == node.ID {
notif = &n
break loopNotif
}
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 56af877c7efa9dabf3a12147d7ae8e1caa6d69db
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.