ovh/cds: engine/hooks/scheduler.go; 25 LoC

Found a possible issue in [ovh/cds](https://www.github.com/ovh/cds) at [engine/hooks/scheduler.go](https://github.com/ovh/cds/blob/56af877c7efa9dabf3a12147d7ae8e1caa6d69db/engine/hooks/scheduler.go#L156-L180)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> function call which takes a reference to e at line 167 may start a goroutine

[Click here to see the code in its original context.](https://github.com/ovh/cds/blob/56af877c7efa9dabf3a12147d7ae8e1caa6d69db/engine/hooks/scheduler.go#L156-L180)

Click here to show the 25 line(s) of Go which triggered the analyzer.

```go
for _, e := range execs {
if e.Status == TaskExecutionScheduled && e.ProcessingTimestamp == 0 && e.Timestamp <= time.Now().UnixNano() {
// update status before enqueue
// this will avoid to re-enqueue the same scheduled task execution if the dequeue take more than 30s (ticker of this goroutine)
if alreadyEnqueued {
log.Info(ctx, "enqueueScheduledTaskExecutionsRoutine > task execution already enqueued for this task %s of type %s- delete it", e.UUID, e.Type)
if err := s.Dao.DeleteTaskExecution(&e); err != nil {
log.Error(ctx, "enqueueScheduledTaskExecutionsRoutine > error on DeleteTaskExecution: %v", err)
}
} else {
e.Status = TaskExecutionEnqueued
s.Dao.SaveTaskExecution(&e)
log.Info(ctx, "enqueueScheduledTaskExecutionsRoutine > Enqueing %s task %s:%d", e.Type, e.UUID, e.Timestamp)
if err := s.Dao.EnqueueTaskExecution(ctx, &e); err != nil {
log.Error(ctx, "enqueueScheduledTaskExecutionsRoutine > error on EnqueueTaskExecution: %v", err)
}
// this will avoid to re-enqueue the same scheduled task execution if the dequeue take more than 30s (ticker of this goroutine)
if e.Type == TypeRepoPoller || e.Type == TypeScheduler {
alreadyEnqueued = true
}

}

}
}

```

Click here to show extra information the analyzer produced.

```
The following paths through the callgraph could lead to a goroutine:
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (start, 4) -> (serve, 4) -> (Serve, 1) -> (int32, 1) -> (QueueJobSetVersion, 3) -> (StatusText, 1) -> (queueDirectArtifactUpload, 5) -> (FormDataContentType, 0) -> (getModels, 1)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (serve, 4)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (serve, 4) -> (Serve, 1)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (ConsumeKafka, 9)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (serve, 4) -> (Serve, 1) -> (int32, 1) -> (QueueJobSetVersion, 3) -> (StatusText, 1) -> (RecordCallWithMethodType, 9)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (start, 4) -> (serve, 4) -> (Serve, 1) -> (int32, 1) -> (QueueJobSetVersion, 3) -> (StatusText, 1) -> (queueDirectArtifactUpload, 5) -> (FormDataContentType, 0)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (serve, 4) -> (Serve, 1) -> (int32, 1) -> (QueueJobSetVersion, 3) -> (StatusText, 1) -> (RecordCallWithMethodType, 9) -> (FormDataContentType, 0) -> (WriteFile, 4) -> (ParseAndImport, 8)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (Init, 1)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (Init, 2) -> (Connect, 0) -> (dirSize, 1) -> (Size, 0)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (checkStaticFiles, 1) -> (askForGettingStaticFiles, 2) -> (buildFromSource, 1) -> (execCommand, 1)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (BeforeStart, 1) -> (Info, 3) -> (InfoWithFields, 4) -> (UpdateColumns, 3) -> (UpdateColumns, 2)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (start, 4) -> (serve, 4) -> (Serve, 1) -> (int32, 1) -> (QueueJobSetVersion, 3)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (start, 4) -> (serve, 4) -> (Serve, 1) -> (int32, 1) -> (QueueJobSetVersion, 3) -> (StatusText, 1)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (start, 4) -> (serve, 4) -> (Serve, 1) -> (int32, 1) -> (QueueJobSetVersion, 3) -> (StatusText, 1) -> (queueDirectArtifactUpload, 5)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (serve, 4) -> (Serve, 1) -> (int32, 1) -> (QueueJobSetVersion, 3) -> (StatusText, 1) -> (RecordCallWithMethodType, 9) -> (FormDataContentType, 0) -> (WriteFile, 4) -> (getModels, 1)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (Run, 3) -> (Update, 2) -> (UpdateColumns, 3)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (start, 4) -> (serve, 4) -> (Serve, 1) -> (int32, 1)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (serve, 4) -> (Serve, 1) -> (int32, 1) -> (QueueJobSetVersion, 3) -> (StatusText, 1)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (serve, 4) -> (Serve, 1) -> (int32, 1) -> (QueueJobSetVersion, 3) -> (StatusText, 1) -> (RecordCallWithMethodType, 9) -> (FormDataContentType, 0) -> (WriteFile, 4)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (start, 4) -> (serve, 4) -> (Serve, 1) -> (int32, 1) -> (QueueJobSetVersion, 3) -> (StatusText, 1) -> (queueDirectArtifactUpload, 5) -> (FormDataContentType, 0) -> (startCmd, 3)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (start, 4) -> (serve, 4) -> (Serve, 1)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (serve, 4) -> (Serve, 1) -> (int32, 1) -> (QueueJobSetVersion, 3)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (serve, 4) -> (Serve, 1) -> (int32, 1) -> (QueueJobSetVersion, 3) -> (StatusText, 1) -> (RecordCallWithMethodType, 9) -> (FormDataContentType, 0)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (serve, 4) -> (Serve, 1) -> (int32, 1) -> (QueueJobSetVersion, 3) -> (StatusText, 1) -> (RecordCallWithMethodType, 9) -> (FormDataContentType, 0) -> (WriteFile, 4) -> (startCmd, 3)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (process, 2) -> (Debugf, 3)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (BeforeStart, 1) -> (Info, 3) -> (InfoWithFields, 4) -> (UpdateColumns, 3)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (start, 4) -> (serve, 4) -> (Serve, 1) -> (int32, 1) -> (QueueJobSetVersion, 3) -> (StatusText, 1) -> (queueDirectArtifactUpload, 5) -> (FormDataContentType, 0) -> (Push, 8) -> (SetPipeline, 1)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (do, 0) -> (process, 2) -> (Debugf, 3)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (start, 4) -> (serve, 4)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (serve, 4) -> (Serve, 1) -> (int32, 1)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (serve, 4) -> (Serve, 1) -> (int32, 1) -> (QueueJobSetVersion, 3) -> (StatusText, 1) -> (RecordCallWithMethodType, 9) -> (FormDataContentType, 0) -> (WriteFile, 4) -> (ParseAndImport, 7)
(SaveTaskExecution, 1) -> (SetAdd, 3) -> (SetWithTTL, 3) -> (Duration, 1) -> (New, 1) -> (init, 0) -> (UTC, 0) -> (Interface, 0) -> (do, 0) -> (process, 2)

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 56af877c7efa9dabf3a12147d7ae8e1caa6d69db