github-vet / github-vet/rangeloop-pointer-findings
Janusec/janusec: backend/destination.go; 12 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [Janusec/janusec](https://www.github.com/Janusec/janusec) at [backend/destination.go](https://github.com/Janusec/janusec/blob/d7b5d57148b6994f461178c9bb71326aa58105f3/backend/destination.go#L34-L45)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable dest used in defer or goroutine at line 37
[Click here to see the code in its original context.](https://github.com/Janusec/janusec/blob/d7b5d57148b6994f461178c9bb71326aa58105f3/backend/destination.go#L34-L45)
Click here to show the 12 line(s) of Go which triggered the analyzer.
```go
for _, dest := range app.Destinations {
if dest.RouteType == models.ReverseProxyRoute && dest.Online == false {
go func() {
conn, err := net.DialTimeout("tcp", dest.Destination, time.Second)
if err == nil {
defer conn.Close()
dest.Online = true
dest.CheckTime = nowTimeStamp
}
}()
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: d7b5d57148b6994f461178c9bb71326aa58105f3
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.