github-vet / github-vet/rangeloop-pointer-findings

elodina/go_kafka_client: fetcher.go; 16 LoC

Open
#7,281 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [elodina/go_kafka_client](https://www.github.com/elodina/go_kafka_client) at [fetcher.go](https://github.com/elodina/go_kafka_client/blob/95d107b0c102fa81b8c1e5e556adc23352fad065/fetcher.go#L333-L348)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> function call which takes a reference to topicAndPartition at line 338 may start a goroutine

[Click here to see the code in its original context.](https://github.com/elodina/go_kafka_client/blob/95d107b0c102fa81b8c1e5e556adc23352fad065/fetcher.go#L333-L348)

Click here to show the 16 line(s) of Go which triggered the analyzer.

```go
for topicAndPartition, info := range partitionTopicInfos {
if _, contains := f.partitionMap[topicAndPartition]; !contains {
f.partitionMap[topicAndPartition] = info
validOffset := info.FetchedOffset + 1
if isOffsetInvalid(info.FetchedOffset) {
f.handleOffsetOutOfRange(&topicAndPartition)
} else {
f.partitionMap[topicAndPartition].FetchedOffset = validOffset
}
f.partitionMap[topicAndPartition].Buffer.start(f.askNext)
newPartitions[topicAndPartition] = f.askNext
if Logger.IsAllowed(DebugLevel) {
Debugf(f, "Owner of %s", topicAndPartition)
}
}
}

```

Click here to show extra information the analyzer produced.

```
The following paths through the callgraph could lead to a goroutine:
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (sendToAllLinks, 3)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (syncSendAndReceive, 2) -> (Return, 1) -> (Broadcast, 0) -> (fun, 0) -> (close, 0)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (syncSendAndReceive, 2) -> (Return, 1) -> (Broadcast, 0) -> (fun, 0) -> (Close, 0) -> (Disconnect, 0)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (syncSendAndReceive, 2) -> (Return, 1) -> (Broadcast, 0) -> (fun, 0) -> (getTLSConfig, 2) -> (AppendCertsFromPEM, 1) -> (fpFilter, 1)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (NewBrokerLink, 4)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (syncSendAndReceive, 2) -> (Return, 1) -> (Broadcast, 0) -> (fun, 0)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (, 0) -> (Sleep, 1) -> (LoggerFromConfigAsBytes, 1) -> (createLoggerFromFullConfig, 1) -> (NewAsyncLoopLogger, 1)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (syncSendAndReceive, 2) -> (Return, 1) -> (Broadcast, 0) -> (fun, 0) -> (AsyncClose, 0)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (syncSendAndReceive, 2) -> (Return, 1) -> (Broadcast, 0) -> (fun, 0) -> (safeAsyncClose, 1)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (syncSendAndReceive, 2) -> (Return, 1) -> (Broadcast, 0) -> (fun, 0) -> (getDirFilePaths, 3) -> (fpFilter, 1)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (syncSendAndReceive, 2) -> (Return, 1) -> (Broadcast, 0) -> (fun, 0) -> (getSortedLogHistory, 0) -> (sortFileRollNamesAsc, 1) -> (Sort, 1)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (sendToAllLinks, 3) -> (check, 1) -> (Return, 1) -> (Broadcast, 0) -> (getTLSConfig, 2) -> (AppendCertsFromPEM, 1) -> (fpFilter, 1)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (syncSendAndReceive, 2) -> (Return, 1)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (sendToAllLinks, 3) -> (check, 1) -> (Return, 1)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (sendToAllLinks, 3) -> (check, 1) -> (Return, 1) -> (Broadcast, 0) -> (Close, 0)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (, 0) -> (Sleep, 1) -> (LoggerFromConfigAsBytes, 1) -> (createLoggerFromFullConfig, 1) -> (NewAsyncTimerLogger, 2)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (, 0) -> (Sleep, 1) -> (LoggerFromConfigAsBytes, 1) -> (createLoggerFromFullConfig, 1) -> (NewAsyncAdaptiveLogger, 4)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (sendToAllLinks, 3) -> (check, 1) -> (Return, 1) -> (Broadcast, 0) -> (createLoggerFromFullConfig, 1) -> (NewAsyncAdaptiveLogger, 4)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (syncSendAndReceive, 2) -> (Return, 1) -> (Broadcast, 0) -> (fun, 0) -> (stopWorkerManagers, 0) -> (Debug, 2)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (syncSendAndReceive, 2) -> (Return, 1) -> (Broadcast, 0) -> (fun, 0) -> (Close, 0) -> (Disconnect, 0) -> (delete, 2)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (syncSendAndReceive, 2) -> (Return, 1) -> (Broadcast, 0) -> (fun, 0) -> (Close, 0)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (sendToAllLinks, 3) -> (check, 1) -> (Return, 1) -> (Broadcast, 0) -> (Close, 0) -> (Disconnect, 0)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (sendToAllLinks, 3) -> (check, 1) -> (Return, 1) -> (Broadcast, 0) -> (Close, 0) -> (Disconnect, 0) -> (delete, 2)
(handleOffsetOutOfRange, 1) -> (GetAvailableOffset, 3) -> (sendToAllAndReturnFirstSuccessful, 2) -> (sendToAllLinks, 3) -> (sendToAllLinks, 3) -> (check, 1) -> (Return, 1) -> (Broadcast, 0) -> (getSortedLogHistory, 0) -> (sortFileRollNamesAsc, 1) -> (Sort, 1)

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 95d107b0c102fa81b8c1e5e556adc23352fad065

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.