github-vet / github-vet/rangeloop-pointer-findings

ParvizBoymurodov/ziper: ziper.go; 9 LoC

Open
#7,237 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [ParvizBoymurodov/ziper](https://www.github.com/ParvizBoymurodov/ziper) at [ziper.go](https://github.com/ParvizBoymurodov/ziper/blob/62cd2fab843cc974d0f97b04e01a4f85b09256b1/ziper.go#L86-L94)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable files used in defer or goroutine at line 91

[Click here to see the code in its original context.](https://github.com/ParvizBoymurodov/ziper/blob/62cd2fab843cc974d0f97b04e01a4f85b09256b1/ziper.go#L86-L94)

Click here to show the 9 line(s) of Go which triggered the analyzer.

```go
for _, files := range file {
filename := fileWay + conArchiveWay + files + ziper
wait.Add(1)
go func( fileName string) {
defer wait.Done()
zipFlies(filename, files)
}( files)

}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 62cd2fab843cc974d0f97b04e01a4f85b09256b1

Contributor guide

No contributing guide indexed for this repository

Research direction

Read ziper.go lines 86-94 and compare the analyzer warning with the closure's captured variables. Decide whether the finding is a Bug, Mitigated, or Desirable Behavior, then leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.