openshift/deadmanssnitch-operator: pkg/controller/deadmanssnitchintegration/deadmanssnitchintegration_controller.go; 49 LoC

Found a possible issue in [openshift/deadmanssnitch-operator](https://www.github.com/openshift/deadmanssnitch-operator) at [pkg/controller/deadmanssnitchintegration/deadmanssnitchintegration_controller.go](https://github.com/openshift/deadmanssnitch-operator/blob/ab50727b546da021c2e63508185c9433b0bd9bb8/pkg/controller/deadmanssnitchintegration/deadmanssnitchintegration_controller.go#L182-L230)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> function call at line 195 may store a reference to clusterdeployment

[Click here to see the code in its original context.](https://github.com/openshift/deadmanssnitch-operator/blob/ab50727b546da021c2e63508185c9433b0bd9bb8/pkg/controller/deadmanssnitchintegration/deadmanssnitchintegration_controller.go#L182-L230)

Click here to show the 49 line(s) of Go which triggered the analyzer.

```go
for _, clusterdeployment := range allClusterDeployments.Items {

// Check if the cluster matches the requirements for needing DMS setup
clusterMatched := false
for _, matchingClusterDeployment := range matchingClusterDeployments.Items {
if clusterdeployment.UID == matchingClusterDeployment.UID {
clusterMatched = true
break
}
}

if !clusterMatched || clusterdeployment.DeletionTimestamp != nil{
// The cluster does not match the criteria for needing DMS setup
if utils.HasFinalizer(&clusterdeployment, deadMansSnitchFinalizer) {
// The cluster has an existing DMS setup, so remove it
err = r.deleteDMSClusterDeployment(dmsi, &clusterdeployment, dmsc)
if err != nil {
return reconcile.Result{}, err
}
}
continue
}

if !clusterdeployment.Spec.Installed {
// The cluster isn't installed yet, so don't setup DMS yet either
continue
}

err = r.dmsAddFinalizer(dmsi, &clusterdeployment)
if err != nil {
return reconcile.Result{}, err
}

err = r.createSnitch(dmsi, &clusterdeployment, dmsc)
if err != nil {
return reconcile.Result{}, err
}

err = r.createSecret(dmsi, dmsc, clusterdeployment)
if err != nil {
return reconcile.Result{}, err
}

err = r.createSyncset(dmsi, clusterdeployment)
if err != nil {
return reconcile.Result{}, err
}

}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: ab50727b546da021c2e63508185c9433b0bd9bb8