github-vet / github-vet/rangeloop-pointer-findings
lpetrea/jenkins-x: pkg/kube/activity.go; 12 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [lpetrea/jenkins-x](https://www.github.com/lpetrea/jenkins-x) at [pkg/kube/activity.go](https://github.com/lpetrea/jenkins-x/blob/687267595ef61c88f21fa935c542ccf2f7ec7d5a/pkg/kube/activity.go#L286-L297)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> function call at line 293 may store a reference to v
[Click here to see the code in its original context.](https://github.com/lpetrea/jenkins-x/blob/687267595ef61c88f21fa935c542ccf2f7ec7d5a/pkg/kube/activity.go#L286-L297)
Click here to show the 12 line(s) of Go which triggered the analyzer.
```go
for _, v := range activities.Items {
if v.Spec.BatchPipelineActivity.BatchBuildNumber != "" {
if buildNumber, err := strconv.Atoi(v.Spec.Build); err == nil {
//Check if it's the previous build, then we can update the PRs and the batch build
if previousBuildNumber == buildNumber {
log.Infof("Found an earlier PipelineActivity for %s and equal lastCommitSha with batch information", labels[v1.LabelBranch])
currentActivity.Spec.BatchPipelineActivity.BatchBuildNumber = v.Spec.BatchPipelineActivity.BatchBuildNumber
return updateBatchBuildComprisingPRs(activitiesClient, currentActivity, v.Spec.BatchPipelineActivity.BatchBuildNumber, &v)
}
}
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 687267595ef61c88f21fa935c542ccf2f7ec7d5a
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.