github-vet / github-vet/rangeloop-pointer-findings
vlado-github/TinyDFS: messaging/messagequeue.go; 10 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [vlado-github/TinyDFS](https://www.github.com/vlado-github/TinyDFS) at [messaging/messagequeue.go](https://github.com/vlado-github/TinyDFS/blob/48bd66e3df1df5ad1b6bf1f8e8daec38435ad6d6/messaging/messagequeue.go#L114-L123)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> function call at line 118 may store a reference to message
[Click here to see the code in its original context.](https://github.com/vlado-github/TinyDFS/blob/48bd66e3df1df5ad1b6bf1f8e8daec38435ad6d6/messaging/messagequeue.go#L114-L123)
Click here to show the 10 line(s) of Go which triggered the analyzer.
```go
for index, message := range queue.messageBuffer {
for _, conn := range queue.pool.conns {
if conn != nil {
encoder := json.NewEncoder(conn)
encodeMessage(&message, encoder)
logging.AddInfo("[Queue] Sending: ", string(message.Payload)+"\n")
}
}
delete(queue.messageBuffer, index)
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 48bd66e3df1df5ad1b6bf1f8e8daec38435ad6d6
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.