github-vet / github-vet/rangeloop-pointer-findings

Dragonbuf/redis: adt/redisObject.go; 3 LoC

Open
#6,999 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [Dragonbuf/redis](https://www.github.com/Dragonbuf/redis) at [adt/redisObject.go](https://github.com/Dragonbuf/redis/blob/14b359cef9818ebbe23636f5655791f02bc60b19/adt/redisObject.go#L116-L118)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> function call at line 117 may store a reference to v

[Click here to see the code in its original context.](https://github.com/Dragonbuf/redis/blob/14b359cef9818ebbe23636f5655791f02bc60b19/adt/redisObject.go#L116-L118)

Click here to show the 3 line(s) of Go which triggered the analyzer.

```go
for _, v := range strings {
obj.List.RPush(NewRedisObject().Set(&v))
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 14b359cef9818ebbe23636f5655791f02bc60b19

Contributor guide

No contributing guide indexed for this repository

Research direction

Read the surrounding code in adt/redisObject.go at lines 116-118 and inspect how Set and RPush use the value passed from the loop. Determine whether the reference to v can be retained incorrectly, then classify the finding as Bug, Mitigated, or Desirable Behavior; completion is a justified classification of this analyzer report.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, redis
Domain
databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.