github-vet / github-vet/rangeloop-pointer-findings
copernet/copernicus: net/syncmanager/syncmanager.go; 5 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [copernet/copernicus](https://www.github.com/copernet/copernicus) at [net/syncmanager/syncmanager.go](https://github.com/copernet/copernicus/blob/46353c3fb80dbfb0da4546a79351ef2d84ed809d/net/syncmanager/syncmanager.go#L582-L586)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> function call at line 583 may store a reference to hash
[Click here to see the code in its original context.](https://github.com/copernet/copernicus/blob/46353c3fb80dbfb0da4546a79351ef2d84ed809d/net/syncmanager/syncmanager.go#L582-L586)
Click here to show the 5 line(s) of Go which triggered the analyzer.
```go
for _, hash := range missTxs {
if !sm.alreadyHave(&hash) {
getData.AddInvVect(wire.NewInvVect(wire.InvTypeTx, &hash))
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 46353c3fb80dbfb0da4546a79351ef2d84ed809d
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.