github-vet / github-vet/rangeloop-pointer-findings

zlepper/go-modpack-packer: source/backend/handlers/buildHandler.go; 19 LoC

Open
#6,981 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [zlepper/go-modpack-packer](https://www.github.com/zlepper/go-modpack-packer) at [source/backend/handlers/buildHandler.go](https://github.com/zlepper/go-modpack-packer/blob/c3d464ab1765c078ed9c4ee636676c36eac162d6/source/backend/handlers/buildHandler.go#L101-L119)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable mod used in defer or goroutine at line 104

[Click here to see the code in its original context.](https://github.com/zlepper/go-modpack-packer/blob/c3d464ab1765c078ed9c4ee636676c36eac162d6/source/backend/handlers/buildHandler.go#L101-L119)

Click here to show the 19 line(s) of Go which triggered the analyzer.

```go
for _, mod := range mods {
wg.Add(1)
go func(m *types.Mod) {
mod.NormalizeAll()
// If the mod already is on solder, then we should likely skip it
// however the user can override this. If they do we should still pack all files
if !modpack.Technic.RepackAllMods && solder.IsOnSolder(solderClient, m) {
conn.Write(packingPartName, m.Filename)
conn.Write(donePackingPartName, m.Filename)
lock.Lock()
infos = append(infos, GenerateOutputInfo(m, ""))
lock.Unlock()
} else {
go packMod(m, conn, outputDirectory, &ch)
}
wg.Done()
}(mod)
total++
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: c3d464ab1765c078ed9c4ee636676c36eac162d6

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.