github-vet / github-vet/rangeloop-pointer-findings

redborian/go-types-to-jsonschema: pkg/crd/flattener.go; 13 LoC

Open
#6,756 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [redborian/go-types-to-jsonschema](https://www.github.com/redborian/go-types-to-jsonschema) at [pkg/crd/flattener.go](https://github.com/redborian/go-types-to-jsonschema/blob/dfd0391f9cc3095a492cb62845aab191d52ad2a5/pkg/crd/flattener.go#L38-L50)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to allOfDef is reassigned at line 47

[Click here to see the code in its original context.](https://github.com/redborian/go-types-to-jsonschema/blob/dfd0391f9cc3095a492cb62845aab191d52ad2a5/pkg/crd/flattener.go#L38-L50)

Click here to show the 13 line(s) of Go which triggered the analyzer.

```go
for _, allOfDef := range definition.AllOf {
var newDef *v1beta1.JSONSchemaProps
if allOfDef.Ref != nil && len(*allOfDef.Ref) > 0 {
// If the definition has $ref url, fetch the referred resource
// after flattening it.
nameOfRef := getNameFromURL(*allOfDef.Ref)
def := defs[nameOfRef]
newDef = recursiveFlatten(defs, &def, nameOfRef, visited)
} else {
newDef = &allOfDef
}
mergeDefinitions(aggregatedDef, newDef)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: dfd0391f9cc3095a492cb62845aab191d52ad2a5

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.