github-vet / github-vet/rangeloop-pointer-findings

swiftycloud/swifty: src/s3/bucket.go; 7 LoC

Open
#6,650 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [swiftycloud/swifty](https://www.github.com/swiftycloud/swifty) at [src/s3/bucket.go](https://github.com/swiftycloud/swifty/blob/611fe46e98f94cf727ffe89b461ac44607be75df/src/s3/bucket.go#L170-L176)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> function call at line 171 may store a reference to bucket

[Click here to see the code in its original context.](https://github.com/swiftycloud/swifty/blob/611fe46e98f94cf727ffe89b461ac44607be75df/src/s3/bucket.go#L170-L176)

Click here to show the 7 line(s) of Go which triggered the analyzer.

```go
for _, bucket := range buckets {
log.Debugf("s3: Detected referenced bucket %s", infoLong(&bucket))
err = s3RepairBucketReference(ctx, &bucket)
if err != nil {
return err
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 611fe46e98f94cf727ffe89b461ac44607be75df

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with src/s3/bucket.go at lines 170-176 and read the surrounding bucket-reference handling. Check the analyzer's report that the call at line 171 may store a reference to bucket, then classify the finding as Bug, Mitigated, or Desirable Behavior using the linked classification guidance and leave the corresponding reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.