github-vet / github-vet/rangeloop-pointer-findings
dhound-io/dhound-output-traffic-monitor: network_monitor.go; 19 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [dhound-io/dhound-output-traffic-monitor](https://www.github.com/dhound-io/dhound-output-traffic-monitor) at [network_monitor.go](https://github.com/dhound-io/dhound-output-traffic-monitor/blob/835b53a5ee425a801fb1e742417a1a882a501231/network_monitor.go#L109-L127)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to device is reassigned at line 111
[Click here to see the code in its original context.](https://github.com/dhound-io/dhound-output-traffic-monitor/blob/835b53a5ee425a801fb1e742417a1a882a501231/network_monitor.go#L109-L127)
Click here to show the 19 line(s) of Go which triggered the analyzer.
```go
for _, device := range devices {
intf := &NetInterfaceInfo{}
intf.NetInterface = &device
intf.Name = device.Name
intf.Active = false
interfaces = append(interfaces, intf)
for _, address := range device.Addresses {
ip := address.IP.String()
if ip != "127.0.0.1" && ip != "0.0.0.0" {
intf.Addresses = append(intf.Addresses, ip)
if Ipv4Validator.MatchString(ip) {
intf.Active = true
}
}
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 835b53a5ee425a801fb1e742417a1a882a501231
Contributor guide
No contributing guide indexed for this repository
Research direction
Open network_monitor.go at lines 109-127 and inspect how the range-loop variable device is referenced and whether the pointer remains valid for each iteration. Compare the behavior with the project's Go context, then classify the finding as Bug, Mitigated, or Desirable Behavior and leave the corresponding reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100