adamsanghera/blurber: replication-daemon/recovery.go; 13 LoC

Found a possible issue in [adamsanghera/blurber](https://www.github.com/adamsanghera/blurber) at [replication-daemon/recovery.go](https://github.com/adamsanghera/blurber/blob/0ddcaec07ca47d9bd42013d2dbf44c8b611888a4/replication-daemon/recovery.go#L43-L55)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable idx used in defer or goroutine at line 51

[Click here to see the code in its original context.](https://github.com/adamsanghera/blurber/blob/0ddcaec07ca47d9bd42013d2dbf44c8b611888a4/replication-daemon/recovery.go#L43-L55)

Click here to show the 13 line(s) of Go which triggered the analyzer.

```go
for idx, client := range srv.peers[:len(srv.peers)-1] {
if idx != int(srv.me) {
log.Printf("PRIMARY: Sending peer list to %s", srv.peerAddresses[idx])

// Spawn a process to share peers with all our buddies
go func(client replication.ReplicationClient) {
_, err := client.SharePeers(context.Background(), &replication.Peers{Addresses: srv.peerAddresses})
if err != nil {
log.Printf("PRIMARY: Failed to connect to client %s", srv.peerAddresses[idx])
}
}(client)
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 0ddcaec07ca47d9bd42013d2dbf44c8b611888a4