github-vet / github-vet/rangeloop-pointer-findings

kontrio/kappy: pkg/kubernetes/deployment_debugger.go; 14 LoC

Open
#6,490 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [kontrio/kappy](https://www.github.com/kontrio/kappy) at [pkg/kubernetes/deployment_debugger.go](https://github.com/kontrio/kappy/blob/05030056792e7b32f787e3728cb11d03f75e837d/pkg/kubernetes/deployment_debugger.go#L27-L40)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to pod is reassigned at line 34

[Click here to see the code in its original context.](https://github.com/kontrio/kappy/blob/05030056792e7b32f787e3728cb11d03f75e837d/pkg/kubernetes/deployment_debugger.go#L27-L40)

Click here to show the 14 line(s) of Go which triggered the analyzer.

```go
for _, pod := range list.Items {
podName := pod.ObjectMeta.Name
log.Infof("Pod: %s Status: %s", podName, pod.Status.Phase)
switch pod.Status.Phase {
case corev1.PodRunning, corev1.PodSucceeded:
continue
case corev1.PodPending:
unknownPods[podName] = &pod
case corev1.PodFailed:
failedPods[podName] = &pod
default:
unknownPods[podName] = &pod
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 05030056792e7b32f787e3728cb11d03f75e837d

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.